Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV File Import: save file as relative #4784

Closed
ajdapretnar opened this issue May 18, 2020 · 2 comments · Fixed by #4872
Closed

CSV File Import: save file as relative #4784

ajdapretnar opened this issue May 18, 2020 · 2 comments · Fixed by #4872
Labels
bug report Bug is reported by user, not yet confirmed by the core team

Comments

@ajdapretnar
Copy link
Contributor

Describe the bug
Sharing workflows with CSV File Import is impossible, because CSV File Import stores absolute path rather than relative.

To Reproduce
Save a workflow with CSV File Import.
Move both the workflow and file somewhere else.
Reload the workflow.

Orange version:
3.26.0.dev

Expected behavior
CSV File Import behaves like File, load the file if it is in the same directory (or subdirectories) to the workflow.

@ajdapretnar ajdapretnar added the bug report Bug is reported by user, not yet confirmed by the core team label May 18, 2020
@ajdapretnar
Copy link
Contributor Author

Not sure if part of this issue, but when trying to reload a file by manually selecting it, settings are not restored.
So the file in CSV File Import widget should be test.csv. I saved it with 'split by semicolon' and such and such column roles.
Then I manually select test.csv on a different computer, because as mentioned above, it didn't load correctly. None of my settings are stored.
The widget should remember separator and everything, then try to apply it to the new file.

@janezd
Copy link
Contributor

janezd commented May 22, 2020

Merged into #3997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug is reported by user, not yet confirmed by the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants