Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] CSV File Import: Add support for explicit workflow relative paths #4872

Merged
merged 22 commits into from
Sep 18, 2020

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Jul 1, 2020

Issue

Fixes gh-4784

Description of changes
  • Add a option to explicitly import a file relative to the workflow file (available only when saved).
  • Add browse for missing functionality which preserves load options/parameters
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the owcsvimport-rel-path branch 2 times, most recently from dd03519 to f2da8a8 Compare July 1, 2020 14:23
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #4872 into master will increase coverage by 0.17%.
The diff coverage is 88.99%.

@@            Coverage Diff             @@
##           master    #4872      +/-   ##
==========================================
+ Coverage   84.49%   84.66%   +0.17%     
==========================================
  Files         283      284       +1     
  Lines       58234    58640     +406     
==========================================
+ Hits        49204    49649     +445     
+ Misses       9030     8991      -39     

@ales-erjavec ales-erjavec force-pushed the owcsvimport-rel-path branch 5 times, most recently from 2761ff1 to a21f345 Compare July 20, 2020 10:01
@ales-erjavec ales-erjavec changed the title [ENH] CSV File Import: Add support for explicit workflow relative paths [NOMERGE][ENH] CSV File Import: Add support for explicit workflow relative paths Jul 20, 2020
@ales-erjavec ales-erjavec force-pushed the owcsvimport-rel-path branch 2 times, most recently from 8b4d8ae to 9407e35 Compare August 10, 2020 11:33
@ales-erjavec ales-erjavec force-pushed the owcsvimport-rel-path branch 3 times, most recently from 1f37729 to 3695a21 Compare August 18, 2020 12:51
@ales-erjavec ales-erjavec changed the title [NOMERGE][ENH] CSV File Import: Add support for explicit workflow relative paths [ENH] CSV File Import: Add support for explicit workflow relative paths Sep 4, 2020
@janezd janezd merged commit 39c7ce8 into biolab:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV File Import: save file as relative
2 participants