Variable: Add sparse flag #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nikicc
force-pushed
the
variable-sparse
branch
from
d0b7088 to
04744ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #2736 +/- ##
=========================================
Coverage ? 76.04%
=========================================
Files ? 338
Lines ? 59644
Branches ? 0
=========================================
Hits ? 45359
Misses ? 14285
Partials ? 0 |
nikicc
force-pushed
the
variable-sparse
branch
3 times, most recently
from
e58fcc4 to
8287dfe
Compare
nikicc
force-pushed
the
variable-sparse
branch
from
8287dfe to
e62a714
Compare
astaric
reviewed
Nov 3, 2017
| @@ -565,12 +571,13 @@ class DiscreteVariable(Variable): | |||
| _all_vars = collections.defaultdict(list) | |||
| presorted_values = [] | |||
|
|
|||
| def __init__(self, name="", values=(), ordered=False, base_value=-1, compute_value=None): | |||
| def __init__(self, name="", values=(), ordered=False, base_value=-1, | |||
| compute_value=None, *, sparse=False): | |||
There was a problem hiding this comment.
@janezd we might want to move * after values, but not in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In order to properly support sparse features, this PR introduces the
Variable.sparseflag, which indicates that the variable suggests to be stored in sparse format.Description of changes
sparseflag to variables.Includes