DiscreteVariable: Remove 'ordered' argument #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
force-pushed
the
remove_ordered
branch
2 times, most recently
from
35f40fa
to
4e7a965
Compare
Codecov Report
@@ Coverage Diff @@
## master #5315 +/- ##
==========================================
- Coverage 85.35% 85.35% -0.01%
==========================================
Files 301 301
Lines 62038 62035 -3
==========================================
- Hits 52951 52948 -3
Misses 9087 9087 |
janezd
reviewed
Mar 10, 2021
Orange/data/variable.py
Outdated
| @@ -35,7 +35,7 @@ def make_variable(cls, compute_value, *args): | |||
| return cls(*args, compute_value=compute_value) | |||
| else: | |||
| # For compatibility with old pickles | |||
| return cls(*args) | |||
| return cls(*tuple(x for i, x in enumerate(args) if i != 2)) | |||
There was a problem hiding this comment.
What about this? @lanzagar, I suppose this should be OK?
# For compatibility with old pickles: remove the second arg if it's bool
# `compute_value` (args[3]) can't be bool, so this should be safe
if len(args) >= 2 and isinstance(args[2], bool):
args = args[:2] + args[3:]
return cls(*args)There was a problem hiding this comment.
if len(args) == 2 this raises an IndexError.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ordered is deprecated and should be removed from constructor.
Description of changes
Remove 'ordered' argument from DiscreteVariable's constructor.
Includes