Revert "XGBoost: Temporary workarounds #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5649 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 315 315
Lines 65958 65954 -4
=======================================
Hits 56759 56759
+ Misses 9199 9195 -4 |
|
Ha! XGBoost didn't fix it, apparently. :( |
janezd
changed the title
3 tasks
|
I suggest that we keep the workaround utill the next xgboost release #5653 and report the issue to xgboost. I haven't had time to find a minimal example yet. |
|
It seems that the error is caused by in combination with scikit-learn=1.0.0. dmlc/xgboost#7355 |
|
@PrimozGodec, scikit-learn just released 1.0.1. Does it fix the issue? Judging by |
|
Oh really. Yes, it should fix the issue. Today in the morning I was wondering when it will happen. 📦 |
|
Let's try if tests pass. |
This reverts commit 1389f99.
PrimozGodec
force-pushed
the
revert-xgboost-workaround
branch
from
0bf9cd0 to
f72a451
Compare
PrimozGodec
changed the title
PrimozGodec
changed the title
PrimozGodec
reviewed
Oct 25, 2021
|
It is ready for review. |
Co-authored-by: Primož Godec <p.godec9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It reverses workaround from pull requests: #5653 and #5613