Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding content for supporting publications modeling #1256

Merged
merged 12 commits into from
Apr 14, 2023

Conversation

mbrush
Copy link
Collaborator

@mbrush mbrush commented Apr 2, 2023

  • updated descriptions of Publication class and publications slot.
  • added a description for 'article', and exact mappings
  • added classes for journal article, patent, preprint, web page, drug label
  • added PMCID to prefix (already referenced in many mappings)

@mbrush mbrush requested review from sierra-moxon and mikebada April 2, 2023 15:35
mbrush and others added 8 commits April 2, 2023 12:19
- fixed indentation error in publications, deprecated supporting documents. added 'supporting documents' as alias to publications (and changed double quotes to single quotes here)
fixed typo (missing space in deprecated:true)
removed spurious tabs in publication class
removing other spurious tabs in newly added class descriptions
removing other spurious tabs in id prefix mappings sections of new classes
clean up spacing / tabs
removed dash from pre-print class name
- NCIT-OBO:C142749
- fabio:WebPage

pre-print publication:
Copy link
Member

@sierra-moxon sierra-moxon Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkml has a hard time with dashes, preprint would work better or pre print (like fabio:Preprint)

@sierra-moxon sierra-moxon marked this pull request as draft April 3, 2023 22:55
@sierra-moxon
Copy link
Member

converted to draft while waiting for review tomorrow.

added PMC prefix and mapping for pubmed central
Copy link
Collaborator

@mikebada mikebada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it's kind of odd to characterize things like, e.g., patents and parts of informational entities like figures and figure legends as publications, but I'm willing to defer to the consensus.

@sierra-moxon sierra-moxon marked this pull request as ready for review April 13, 2023 15:15
@sierra-moxon sierra-moxon merged commit 0fbc3c6 into master Apr 14, 2023
@RichardBruskiewich RichardBruskiewich deleted the mbrush-supporting_pubs-patch branch July 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants