Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semmeddb mappings per analysis in #1292, fixes #1295 #1294

Merged
merged 11 commits into from
Apr 26, 2023

Conversation

sierra-moxon
Copy link
Member

No description provided.

@sierra-moxon sierra-moxon requested a review from balhoff April 26, 2023 00:32
@sierra-moxon
Copy link
Member Author

Hi @balhoff - would you mind taking a look at my mappings here, to see if you agree? :) happy for feedback!

@sierra-moxon sierra-moxon changed the title Semmeddb mappings per analysis in #1292 Semmeddb mappings per analysis in #1292, fixes #1295 Apr 26, 2023
@sierra-moxon sierra-moxon merged commit 8dec8cc into master Apr 26, 2023
Copy link
Contributor

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of mapping suggestions.

including mushrooms, yeasts, smuts, molds, etc. They reproduce either sexually or
asexually, and have life cycles that range from simple to complex. Filamentous
fungi refer to those that grow as multicellular colonies (mushrooms and molds).
exact_mappings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also NCBITaxon:4751

plant:
is_a: cellular organism
description: >-
exact_mappings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also NCBITaxon:33090

@RichardBruskiewich RichardBruskiewich deleted the semmeddb_mappings branch July 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants