Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Yarn PnP support #126

Closed
nhedger opened this issue Feb 11, 2024 · 1 comment · Fixed by #134
Closed

📎 Yarn PnP support #126

nhedger opened this issue Feb 11, 2024 · 1 comment · Fixed by #134
Labels
Enhancement Improves an existing feature Good first issue Help wanted External contributions are welcome

Comments

@nhedger
Copy link
Member

nhedger commented Feb 11, 2024

Summary

This task tracks the implementation of Yarn PnP support for resolving the biome binary from a project's dependencies.

Yarn PnP uses a different strategy for installing dependencies that does not involve a node_modules folder, which is what we've been relying on with other package managers.

Ideally, we shouldn't have to rely on executing an external command to find the path to the binary, but it is unclear if that's even possible.

Reference

Contributing

If you'd like to contribute and implement this, please make it known in the comments so we can assign you to the task.

@nhedger nhedger added Enhancement Improves an existing feature Help wanted External contributions are welcome Good first issue labels Feb 11, 2024
@nhedger nhedger pinned this issue Feb 11, 2024
@roblillack
Copy link
Contributor

Added a pull request for this: #134

@nhedger nhedger linked a pull request Feb 13, 2024 that will close this issue
@nhedger nhedger unpinned this issue Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improves an existing feature Good first issue Help wanted External contributions are welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants