Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Yarn PnP support #134

Merged
merged 5 commits into from
Feb 13, 2024
Merged

feat: add Yarn PnP support #134

merged 5 commits into from
Feb 13, 2024

Conversation

roblillack
Copy link
Contributor

This PR adds support for using Yarn's PnP linker when resolving the path of the biome binary to use.

@roblillack roblillack mentioned this pull request Feb 13, 2024
Closed
ematipico
ematipico reviewed Feb 13, 2024
View reviewed changes
src/main.ts Show resolved Hide resolved
nhedger
nhedger reviewed Feb 13, 2024
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
@roblillack
Copy link
Contributor Author

roblillack commented Feb 13, 2024 •
edited
Loading

Here's a minimal repo which can be used to play around with this change: https://gist.github.com/roblillack/5818b0dbb5bfd69757bc4397ff6f8b32

@roblillack
Copy link
Contributor Author

Another Gist with a Yarn v1 repo here: https://gist.github.com/roblillack/a0437af4db73b4cc746259d010375994

nhedger
nhedger approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@nhedger nhedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thank you, @roblillack!

@nhedger nhedger linked an issue Feb 13, 2024 that may be closed by this pull request
📎 Yarn PnP support #126
Closed
@nhedger nhedger changed the title feat: Support Yarn PnP for resolving project-specific biome binary feat: add Yarn PnP support Feb 13, 2024
@roblillack roblillack requested a review from ematipico February 13, 2024 14:11
@nhedger
Copy link
Member

nhedger commented Feb 13, 2024 •
edited
Loading

I've reverted the switch from require to import because it prevented detection on windows.

@nhedger nhedger merged commit 436d438 into biomejs:main Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhedger nhedger nhedger approved these changes

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Yarn PnP support
3 participants
@roblillack @nhedger @ematipico