Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: musl libc detection #224

Merged
merged 3 commits into from
May 25, 2024
Merged

fix: musl libc detection #224

merged 3 commits into from
May 25, 2024

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented May 25, 2024

Summary

This PR fixes the musl libc detection, allowing the extension to select the correct biome binary from the project's dependencies.

Related Issue

This PR closes #223

Checklist

  • I have tested my changes on the following platforms:
    • Windows
    • Linux
    • macOS

@nhedger nhedger marked this pull request as ready for review May 25, 2024 19:29
@nhedger nhedger changed the title chore: remove dead code fix: musl libc detection May 25, 2024
@nhedger nhedger merged commit 220517b into main May 25, 2024
11 checks passed
@nhedger nhedger deleted the fix/musl branch May 25, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Wrong biome build used for musl guest devcontainer on arm64 host
1 participant