fix: only watch lock files in workspace root

[ChiefORZ]

Closes biomejs/biome#1601

[nhedger]

I'm wondering if instead we shouldn't just watch lockfiles in the root of the workspace folder.

[ChiefORZ]

@nhedger but then there could be the risk that lockfiles in a multi-root vscode workspace - will not trigger a reload. just a mind of though because i personally work with multi-root workspaces. but im no expert in how vscode works

[nhedger]

At this time we do not support multiple workspace folders. We're hoping to add support soon though.

That being said, nothing would prevent us from creating a watcher per workspace folder if we needed to.

The reason I proposed this is because currently the extension will use biome from the dependencies declared at the root of your project anyway, so watching lock files deeper in the hierarchy is basically useless.

[nhedger]

I've tested the code, and unfortunately, it looks like VS Code's workspace.createFileSystemWatcher function does not yet support excluding files from watching, so this glob pattern won't prevent changes in .wireit/lock.lock files from being detected.

There is an open issue about it here: microsoft/vscode#169724

In the meantime, I think changing the glob pattern to only watch for lock files in the root of the workspace folder is the way to go.

[ChiefORZ]

@nhedger the PR always fails because in our codebase the "source.organizeImports.biome" does not work like it is described in biome's docs - we need the additional "source.organizeImports" to be enabled too.

{
  "editor.codeActionsOnSave": {
    "source.organizeImports": "explicit",
    "source.organizeImports.biome": "explicit",
  }
}

With this codebase there is a race condition, so i have to disable the "source.organizeImports" rule and it works. But then our codebase stops working - do you maybe have any insights in why this is happening?

[nhedger]

Gotcha, would you mind filing an issue for this problem?

[nhedger]

I've updated to a RelativePattern, because otherwise the watcher won't work as expected. See microsoft/vscode#31602

[nhedger]

Thanks for you contribution @ChiefORZ!