fix(formatter): escape double quotes when printing formatter IR

biomejs · Jun 1, 2024 · e10f09e · e10f09e
1 parent bc30892
commit e10f09e
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/crates/biome_formatter/src/format_element/document.rs b/crates/biome_formatter/src/format_element/document.rs
@@ -250,7 +250,23 @@ impl Format<IrFormatContext> for &[FormatElement] {
                         FormatElement::Space | FormatElement::HardSpace => {
                             write!(f, [text(" ")])?;
                         }
-                        element if element.is_text() => f.write_element(element.clone())?,
+                        element if element.is_text() => {
+                            // escape quotes
+                            let new_element = match element {
+                                // except for static text because source_position is unknown
+                                FormatElement::StaticText { .. } => element.clone(),
+                                FormatElement::DynamicText { text, source_position } => {
+                                    let text = text.to_string().replace("\"", "\\\"");
+                                    FormatElement::DynamicText { text: text.into(), source_position: *source_position }
+                                },
+                                FormatElement::LocatedTokenText { slice, source_position } => {
+                                    let text = slice.to_string().replace("\"", "\\\"");
+                                    FormatElement::DynamicText { text: text.into(), source_position: *source_position }
+                                },
+                                _ => unreachable!(),
+                            };
+                            f.write_element(new_element)?;
+                        },
                         _ => unreachable!(),
                     }