chore(linter): rename some css linter rules (#3818)

biomejs · Sep 7, 2024 · e50a3a4 · e50a3a4
1 parent 26f4663
commit e50a3a4
Show file tree

Hide file tree

Showing 19 changed files with 66 additions and 62 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,9 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 - Add support of comments in `turbo.json`. Contributed by @Netail
 - Implement [semantic model for CSS](https://github.com/biomejs/biome/pull/3546). Contributed by @togami2864
 - Integrate CSS semantic model into the analyzer. Contributed by @togami2864
+- Rename `use-consistent-grid-areas` to `no-invalid-grid-areas` by @togami2864
+- Rename `no_unknown_pseudo_class_selector` to `no_unknown_pseudo_class` by @togami2864
+- Rename `no_unknown_selector_pseudo_element` to `no_unknown_pseudo_element` by @togami2864
 
 ### CLI
 
@@ -1212,7 +1215,7 @@ New rules are incubated in the nursery group. Once stable, we promote them to a
 - Add [nursery/noUnknownFunction](https://biomejs.dev/linter/rules/no-unknown-function). [#2570](https://github.com/biomejs/biome/pull/2570) Contributed by @neokidev
 - Add [nursery/noUnknownMediaFeatureName](https://biomejs.dev/linter/rules/no-unknown-media-feature-name). [#2751](https://github.com/biomejs/biome/issues/2751) Contributed by @Kazuhiro-Mimaki
 - Add [nursery/noUnknownProperty](https://biomejs.dev/linter/rules/no-unknown-property). [#2755](https://github.com/biomejs/biome/pull/2755) Contributed by @chansuke
-- Add [nursery/noUnknownSelectorPseudoElement](https://biomejs.dev/linter/rules/no-unknown-selector-pseudo-element). [#2655](https://github.com/biomejs/biome/issues/2655) Contributed by @keita-hino
+- Add [nursery/noUnknownPseudoElement](https://biomejs.dev/linter/rules/no-unknown-selector-pseudo-element). [#2655](https://github.com/biomejs/biome/issues/2655) Contributed by @keita-hino
 - Add [nursery/noUnknownUnit](https://biomejs.dev/linter/rules/no-unknown-unit). [#2535](https://github.com/biomejs/biome/issues/2535) Contributed by @neokidev
 - Add [nursery/noUnmatchableAnbSelector](https://biomejs.dev/linter/rules/no-unmatchable-anb-selector). [#2706](https://github.com/biomejs/biome/issues/2706) Contributed by @togami2864
 - Add [nursery/useGenericFontNames](https://biomejs.dev/linter/rules/use-generic-font-names). [#2573](https://github.com/biomejs/biome/pull/2573) Contributed by @togami2864

diff --git a/crates/biome_configuration/src/analyzer/linter/rules.rs b/crates/biome_configuration/src/analyzer/linter/rules.rs
@@ -2981,12 +2981,12 @@ pub struct Nursery {
         Option<RuleConfiguration<biome_css_analyze::options::NoUnknownProperty>>,
     #[doc = "Disallow unknown pseudo-class selectors."]
     #[serde(skip_serializing_if = "Option::is_none")]
-    pub no_unknown_pseudo_class_selector:
-        Option<RuleConfiguration<biome_css_analyze::options::NoUnknownPseudoClassSelector>>,
+    pub no_unknown_pseudo_class:
+        Option<RuleConfiguration<biome_css_analyze::options::NoUnknownPseudoClass>>,
     #[doc = "Disallow unknown pseudo-element selectors."]
     #[serde(skip_serializing_if = "Option::is_none")]
-    pub no_unknown_selector_pseudo_element:
-        Option<RuleConfiguration<biome_css_analyze::options::NoUnknownSelectorPseudoElement>>,
+    pub no_unknown_pseudo_element:
+        Option<RuleConfiguration<biome_css_analyze::options::NoUnknownPseudoElement>>,
     #[doc = "Disallow unknown CSS units."]
     #[serde(skip_serializing_if = "Option::is_none")]
     pub no_unknown_unit: Option<RuleConfiguration<biome_css_analyze::options::NoUnknownUnit>>,
@@ -3152,8 +3152,8 @@ impl Nursery {
         "noUnknownFunction",
         "noUnknownMediaFeatureName",
         "noUnknownProperty",
-        "noUnknownPseudoClassSelector",
-        "noUnknownSelectorPseudoElement",
+        "noUnknownPseudoClass",
+        "noUnknownPseudoElement",
         "noUnknownUnit",
         "noUnmatchableAnbSelector",
         "noUnusedFunctionParameters",
@@ -3201,8 +3201,8 @@ impl Nursery {
         "noShorthandPropertyOverrides",
         "noUnknownFunction",
         "noUnknownProperty",
-        "noUnknownPseudoClassSelector",
-        "noUnknownSelectorPseudoElement",
+        "noUnknownPseudoClass",
+        "noUnknownPseudoElement",
         "noUnknownUnit",
         "noUnmatchableAnbSelector",
         "noUselessEscapeInRegex",
@@ -3466,12 +3466,12 @@ impl Nursery {
                 index_set.insert(RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[28]));
             }
         }
-        if let Some(rule) = self.no_unknown_pseudo_class_selector.as_ref() {
+        if let Some(rule) = self.no_unknown_pseudo_class.as_ref() {
             if rule.is_enabled() {
                 index_set.insert(RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[29]));
             }
         }
-        if let Some(rule) = self.no_unknown_selector_pseudo_element.as_ref() {
+        if let Some(rule) = self.no_unknown_pseudo_element.as_ref() {
             if rule.is_enabled() {
                 index_set.insert(RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[30]));
             }
@@ -3780,12 +3780,12 @@ impl Nursery {
                 index_set.insert(RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[28]));
             }
         }
-        if let Some(rule) = self.no_unknown_pseudo_class_selector.as_ref() {
+        if let Some(rule) = self.no_unknown_pseudo_class.as_ref() {
             if rule.is_disabled() {
                 index_set.insert(RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[29]));
             }
         }
-        if let Some(rule) = self.no_unknown_selector_pseudo_element.as_ref() {
+        if let Some(rule) = self.no_unknown_pseudo_element.as_ref() {
             if rule.is_disabled() {
                 index_set.insert(RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[30]));
             }
@@ -4097,12 +4097,12 @@ impl Nursery {
                 .no_unknown_property
                 .as_ref()
                 .map(|conf| (conf.level(), conf.get_options())),
-            "noUnknownPseudoClassSelector" => self
-                .no_unknown_pseudo_class_selector
+            "noUnknownPseudoClass" => self
+                .no_unknown_pseudo_class
                 .as_ref()
                 .map(|conf| (conf.level(), conf.get_options())),
-            "noUnknownSelectorPseudoElement" => self
-                .no_unknown_selector_pseudo_element
+            "noUnknownPseudoElement" => self
+                .no_unknown_pseudo_element
                 .as_ref()
                 .map(|conf| (conf.level(), conf.get_options())),
             "noUnknownUnit" => self

diff --git a/crates/biome_css_analyze/src/lib.rs b/crates/biome_css_analyze/src/lib.rs
@@ -177,7 +177,7 @@ mod tests {
         let parsed = parse_css(SOURCE, CssParserOptions::default());
 
         let mut error_ranges: Vec<TextRange> = Vec::new();
-        let rule_filter = RuleFilter::Rule("nursery", "noUnknownPseudoClassSelector");
+        let rule_filter = RuleFilter::Rule("nursery", "noUnknownPseudoClass");
         let options = AnalyzerOptions::default();
         analyze(
             &parsed.tree(),

diff --git a/crates/biome_css_analyze/src/lint/nursery.rs b/crates/biome_css_analyze/src/lint/nursery.rs
@@ -15,8 +15,8 @@ pub mod no_shorthand_property_overrides;
 pub mod no_unknown_function;
 pub mod no_unknown_media_feature_name;
 pub mod no_unknown_property;
-pub mod no_unknown_pseudo_class_selector;
-pub mod no_unknown_selector_pseudo_element;
+pub mod no_unknown_pseudo_class;
+pub mod no_unknown_pseudo_element;
 pub mod no_unknown_unit;
 pub mod no_unmatchable_anb_selector;
 pub mod no_value_at_rule;
@@ -39,8 +39,8 @@ declare_lint_group! {
             self :: no_unknown_function :: NoUnknownFunction ,
             self :: no_unknown_media_feature_name :: NoUnknownMediaFeatureName ,
             self :: no_unknown_property :: NoUnknownProperty ,
-            self :: no_unknown_pseudo_class_selector :: NoUnknownPseudoClassSelector ,
-            self :: no_unknown_selector_pseudo_element :: NoUnknownSelectorPseudoElement ,
+            self :: no_unknown_pseudo_class :: NoUnknownPseudoClass ,
+            self :: no_unknown_pseudo_element :: NoUnknownPseudoElement ,
             self :: no_unknown_unit :: NoUnknownUnit ,
             self :: no_unmatchable_anb_selector :: NoUnmatchableAnbSelector ,
             self :: no_value_at_rule :: NoValueAtRule ,

diff --git a/...rsery/no_unknown_pseudo_class_selector.rs → ...c/lint/nursery/no_unknown_pseudo_class.rs b/...rsery/no_unknown_pseudo_class_selector.rs → ...c/lint/nursery/no_unknown_pseudo_class.rs
@@ -56,9 +56,9 @@ declare_lint_rule! {
     /// input:-moz-placeholder {}
     /// ```
     ///
-    pub NoUnknownPseudoClassSelector {
+    pub NoUnknownPseudoClass {
         version: "next",
-        name: "noUnknownPseudoClassSelector",
+        name: "noUnknownPseudoClass",
         language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("selector-pseudo-class-no-unknown")],
@@ -105,7 +105,7 @@ pub struct NoUnknownPseudoClassSelectorState {
     class_type: PseudoClassType,
 }
 
-impl Rule for NoUnknownPseudoClassSelector {
+impl Rule for NoUnknownPseudoClass {
     type Query = Ast<AnyPseudoLike>;
     type State = NoUnknownPseudoClassSelectorState;
     type Signals = Option<Self::State>;

diff --git a/...ery/no_unknown_selector_pseudo_element.rs → ...lint/nursery/no_unknown_pseudo_element.rs b/...ery/no_unknown_selector_pseudo_element.rs → ...lint/nursery/no_unknown_pseudo_element.rs
@@ -48,16 +48,16 @@ declare_lint_rule! {
     /// input::-moz-placeholder {}
     /// ```
     ///
-    pub NoUnknownSelectorPseudoElement {
+    pub NoUnknownPseudoElement {
         version: "1.8.0",
-        name: "noUnknownSelectorPseudoElement",
+        name: "noUnknownPseudoElement",
         language: "css",
         recommended: true,
         sources: &[RuleSource::Stylelint("selector-pseudo-element-no-unknown")],
     }
 }
 
-impl Rule for NoUnknownSelectorPseudoElement {
+impl Rule for NoUnknownPseudoElement {
     type Query = Ast<CssPseudoElementSelector>;
     type State = AnyCssPseudoElement;
     type Signals = Option<Self::State>;

diff --git a/crates/biome_css_analyze/src/options.rs b/crates/biome_css_analyze/src/options.rs
diff --git a/.../noUnknownPseudoClassSelector/invalid.css → .../nursery/noUnknownPseudoClass/invalid.css b/.../noUnknownPseudoClassSelector/invalid.css → .../nursery/noUnknownPseudoClass/invalid.css
diff --git a/...knownPseudoClassSelector/invalid.css.snap → ...ery/noUnknownPseudoClass/invalid.css.snap b/...knownPseudoClassSelector/invalid.css.snap → ...ery/noUnknownPseudoClass/invalid.css.snap
@@ -24,7 +24,7 @@ b > .foo:error { }
 
 # Diagnostics
 ```
-invalid.css:1:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:1:3 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class unknown 
   
@@ -39,7 +39,7 @@ invalid.css:1:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:2:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:2:3 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class Unknown 
   
@@ -55,7 +55,7 @@ invalid.css:2:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:3:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:3:3 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class uNkNoWn 
   
@@ -72,7 +72,7 @@ invalid.css:3:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:4:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:4:3 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class UNKNOWN 
   
@@ -89,7 +89,7 @@ invalid.css:4:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:5:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:5:3 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class pseudo-class 
   
@@ -106,7 +106,7 @@ invalid.css:5:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:6:15 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:6:15 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class noot 
   
@@ -123,7 +123,7 @@ invalid.css:6:15 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:7:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:7:3 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class unknown 
   
@@ -140,7 +140,7 @@ invalid.css:7:3 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:9:10 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:9:10 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class error 
   
@@ -157,7 +157,7 @@ invalid.css:9:10 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:10:39 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:10:39 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class unknown 
   
@@ -174,7 +174,7 @@ invalid.css:10:39 lint/nursery/noUnknownPseudoClassSelector ━━━━━━
 ```
 
 ```
-invalid.css:11:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:11:2 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class first 
   
@@ -191,7 +191,7 @@ invalid.css:11:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:12:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:12:2 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class slotted 
   
@@ -208,7 +208,7 @@ invalid.css:12:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:13:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:13:2 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class placeholder 
   
@@ -225,7 +225,7 @@ invalid.css:13:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:14:14 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:14:14 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class unknown 
   
@@ -242,7 +242,7 @@ invalid.css:14:14 lint/nursery/noUnknownPseudoClassSelector ━━━━━━
 ```
 
 ```
-invalid.css:15:11 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:15:11 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class unknown 
   
@@ -258,7 +258,7 @@ invalid.css:15:11 lint/nursery/noUnknownPseudoClassSelector ━━━━━━
 ```
 
 ```
-invalid.css:16:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:16:2 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class horizontal 
   
@@ -273,7 +273,7 @@ invalid.css:16:2 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━
 ```
 
 ```
-invalid.css:16:13 lint/nursery/noUnknownPseudoClassSelector ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:16:13 lint/nursery/noUnknownPseudoClass ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Unexpected unknown pseudo-class decrement 
   

diff --git a/...ry/noUnknownPseudoClassSelector/valid.css → ...cs/nursery/noUnknownPseudoClass/valid.css b/...ry/noUnknownPseudoClassSelector/valid.css → ...cs/nursery/noUnknownPseudoClass/valid.css
diff --git a/...UnknownPseudoClassSelector/valid.css.snap → ...rsery/noUnknownPseudoClass/valid.css.snap b/...UnknownPseudoClassSelector/valid.css.snap → ...rsery/noUnknownPseudoClass/valid.css.snap
diff --git a/...oUnknownSelectorPseudoElement/invalid.css → ...ursery/noUnknownPseudoElement/invalid.css b/...oUnknownSelectorPseudoElement/invalid.css → ...ursery/noUnknownPseudoElement/invalid.css