📎 Change bitflags for enumflags2

[ematipico]

Description

Inside the biome_js_analyze, we started using enumflags2, and the DX has been positive.

This is a task to remove bitflags from the codebase, and use enumflags2. This is an example of definition:

biome/crates/biome_js_syntax/src/modifier_ext.rs

Lines 12 to 27 in b75d30e

	#[enumflags2::bitflags]
	#[repr(u16)]
	pub enum Modifier {
	// modifiers must be sorted by precedence.
	Decorator = 1 << 0,
	BogusAccessibility = 1 << 1,
	Private = 1 << 2,
	Protected = 1 << 3,
	Public = 1 << 4,
	Declare = 1 << 5,
	Static = 1 << 6,
	Abstract = 1 << 7,
	Override = 1 << 8,
	Readonly = 1 << 9,
	Accessor = 1 << 10,
	}

Feel free to send multiple PRs to address this, we use bit_flags in different places of the repository.

[mvares]

@ematipico, is there still work to be done here?

[dyc3]

Nope, this should have been closed in #3529.

[dyc3]

Wait, nevermind, the package name is actually bitflags without the underscore (edited the issue to fix that)

This is where we currently still depend on bitflags: https://github.com/search?q=repo%3Abiomejs%2Fbiome+bitflags+language%3ATOML&type=code&l=TOML

[ematipico]

@ematipico, is there still work to be done here?

@mvares yes, mostly biome_js_parser

There, I suggest porting one bitflag at the time, because there are a lot.

[mvares]

@ematipico I'll start contribuing to biome. If I'd have some help, can I ask here?

[ematipico]

Of course!

[Javimtib92]

I would like to contribute for the first time to Biome, could I contribute to this issue as well @ematipico ? . I would work on refactoring biome_diagnostics if that's ok to you.

[dyc3]

Yes, absolutely. As previously stated though, refactor one flag per PR so it's easier for us to review.