Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 json shcema for options of useExhaustiveDependencies incorrectly requires stableResult #3763

Closed
1 task done
anatawa12 opened this issue Sep 2, 2024 · 0 comments · Fixed by #3764
Closed
1 task done
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@anatawa12
Copy link

Environment information

CLI:
  Version:                      1.8.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v22.6.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.8.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

json shcema for options of useExhaustiveDependencies incorrectly requires stableResult

When I wrote biome.json like below, my IDE reports Missing required property 'stableResult'

"useExhaustiveDependencies": {
	"level": "error",
	"options": {
		"hooks": [
			{
				"name": "useDocumentEvent",
				"closureIndex": 1,
				"dependenciesIndex": 2
			}
		]
	}
},

I read configuration_schema.json and I found stableResult is marked required in #/definitions/Hook.

"required": ["name", "stableResult"],

However, in documentation, stableResult is not specified and it works without stableResult

Expected result

stableResult should not marked as required

Code of Conduct

  • I agree to follow Biome's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants