Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 json schema for noLabelWithoutControl incorrectly requires inputComponents labelAttributes labelComponents #4125

Closed
1 task done
anatawa12 opened this issue Sep 30, 2024 · 2 comments · Fixed by #4138 or WomB0ComB0/portfolio#159
Assignees

Comments

@anatawa12
Copy link

Environment information

CLI:
  Version:                      1.9.2
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v22.6.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.8.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

  1. We configured inputComponents for our components
  2. IDE says labelAttributes and labelComponents are required attributes, but biome cli correctly parses the configuration JSON so I think this is false-positive

Expected result

I think labelAttributes and labelComponents should not be marked as required in json schema, if biome cli accepts json without them

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@anatawa12
Copy link
Author

anatawa12 commented Sep 30, 2024

This is similar to #3763 and there might be several similar other places. Should I create issue for each time I found or send new ones as comment for some existing issue?

@ematipico
Copy link
Member

This is similar to #3763 and there might be several similar other places. Should I create issue for each time I found or send new ones as comment for some existing issue?

Yes please. Every option is different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment