Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): options for noLabelWithoutControl are optional #4138

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Sep 30, 2024

Summary

Closes #4125

I updated the contribution guide too. I took the opportunity to do some small refactor, and move functions inside the options struct, so we don't pass around the same object.

Test Plan

CI should pass. I checked the code generated files manually.

@ematipico ematipico requested review from a team September 30, 2024 12:10
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Sep 30, 2024
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #4138 will degrade performances by 39.46%

Comparing fix/no-label-without-control (01de10b) with main (10a1371)

Summary

❌ 2 regressions
✅ 103 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/no-label-without-control Change
pure_9395922602181450299.css[cached] 3.4 ms 3.6 ms -6.59%
big5-added_15586211152145260264.json[uncached] 551.1 µs 910.3 µs -39.46%

CHANGELOG.md Show resolved Hide resolved
@ematipico ematipico force-pushed the fix/no-label-without-control branch from ee2ba26 to f723737 Compare October 1, 2024 07:51
@ematipico ematipico force-pushed the fix/no-label-without-control branch from f723737 to 01de10b Compare October 1, 2024 07:55
@ematipico ematipico requested review from Conaclos and arendjr October 1, 2024 07:55
@ematipico ematipico merged commit 7e29f06 into main Oct 1, 2024
14 of 15 checks passed
@ematipico ematipico deleted the fix/no-label-without-control branch October 1, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
3 participants