Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analyzer): useSortedKeys for JSON objects #2412

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Apr 11, 2024

Summary

This PR adds the useSortedKeys assist for JSON objects.

This is the first assist (excluded organizeImports, which is an exception) of the analyzer, and I intend to make more PR to off the foundation of this new feature.

I will open an issue to track the work.

Test Plan

CI should pass

@github-actions github-actions bot added A-Linter Area: linter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis labels Apr 11, 2024
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50787 50787 0
Passed 49680 49680 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6534 6534 0
Passed 2087 2087 0
Failed 4447 4447 0
Panics 0 0 0
Coverage 31.94% 31.94% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18217 18217 0
Passed 13961 13961 0
Failed 4256 4256 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #2412 will not alter performance

Comparing feat/use-sorted-keys (4784318) with main (eca1507)

Summary

✅ 90 untouched benchmarks

@ematipico ematipico added the S-Feature Status: new feature to implement label May 3, 2024
@ematipico ematipico added this to the Biome 1.8 milestone May 6, 2024
@Conaclos Conaclos modified the milestones: Biome 1.8, Biome 1.9 Jun 3, 2024
@github-actions github-actions bot added the A-Project Area: project label Jun 11, 2024
@biomejs biomejs deleted a comment from netlify bot Jun 11, 2024
@ematipico ematipico marked this pull request as ready for review June 11, 2024 09:06
@ematipico ematipico merged commit e3e93cc into main Jun 11, 2024
17 checks passed
@ematipico ematipico deleted the feat/use-sorted-keys branch June 11, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages S-Feature Status: new feature to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants