feat(biome_css_analyzer): noCssEmptyBlock #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #2513 will improve performances by 6.38%Comparing Summary
Benchmarks breakdown
|
ematipico
reviewed
Apr 18, 2024
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| declare_rule! { | ||
| /// Disallow css empty blocks. |
There was a problem hiding this comment.
Suggested change
| /// Disallow css empty blocks. | |
| /// Disallow CSS empty blocks. |
| declare_rule! { | ||
| /// Disallow css empty blocks. | ||
| /// | ||
| /// This rule disallows empty block. |
There was a problem hiding this comment.
Suggested change
| /// This rule disallows empty block. |
Repetition of the previous sentence.
| /// { | ||
| /// "noCssEmptyBlock": { | ||
| /// "options": { | ||
| /// "ignore": ["comments"] |
There was a problem hiding this comment.
This option - coming from Styelint- isn't very... good. If by adding this option we allow comments in blocks, then why not "options": { "allowComments": true }?
Also, it's really hard to understand what's the default behaviour of the rule, which we should explain in the documentation.
| rule_category!(), | ||
| span, | ||
| markup! { | ||
| "Unexpected empty block is not allowed" |
There was a problem hiding this comment.
Suggested change
| "Unexpected empty block is not allowed" | |
| "Empty blocks aren't allowed." |
togami2864
force-pushed
the
feat/no-css-empty-block
branch
from
a7d229e to
d1d4206
Compare
ematipico
approved these changes
Apr 19, 2024
crates/biome_css_analyze/src/lint/nursery/no_css_empty_block.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Apr 19, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #2512
Implement block-no-empty
Test Plan
added tests and snapshots