-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_service,biome_cli): resolve .editorconfig
files and merge configuration
#2884
feat(biome_service,biome_cli): resolve .editorconfig
files and merge configuration
#2884
Conversation
c1a2d1c
to
9e52d18
Compare
9e52d18
to
29a3a97
Compare
crates/biome_cli/tests/snapshots/main_cases_editorconfig/should_use_editorconfig.snap
Outdated
Show resolved
Hide resolved
8c60319
to
f9ccaa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions and changes to improve the quality of the PR. We are almost there, we just need to add more test cases to cover the new errors
f9ccaa5
to
0d8c22b
Compare
CodSpeed Performance ReportMerging #2884 will not alter performanceComparing Summary
|
0d8c22b
to
5e1b6f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my concerns are addressed, thank you ❤️
5e1b6f8
to
ab79531
Compare
ab79531
to
c8455ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time for addressing my pedantic concerns, that's really appreciated!
Summary
This is part of a series of PRs to add
.editorconfig
support to biome. As with the previous PR, this is intentionally small to help make code reviews easier. The goal is to add functions that look for and load the .editorconfig files, and merge the loaded configurations.Here's how the configurations are prioritized:
biome.json
biome.json
overrides.editorconfig
.editorconfig
overrides biome defaultsRelated to: #1724
Test Plan
I've added one test just to show that it works in this PR, but I have more tests in another branch that I could bring into this PR instead of making another one.