feat(editorconfig): expand unknown globs into known globs #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
06-15-feat_editorconfig_expand_unknown_globs_into_known_globs
branch
2 times, most recently
from
516e9d0
to
f9ed9e9
Compare
dyc3
force-pushed
the
06-15-feat_editorconfig_expand_unknown_globs_into_known_globs
branch
from
f9ed9e9
to
2b59edf
Compare
|
Assigned to myself, hopefully I'll remember |
dyc3
deleted the
06-15-feat_editorconfig_expand_unknown_globs_into_known_globs
branch
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes it so that we can fully support all editorconfig glob patterns. Adding support to the vendored
globpackage is already done, but the functionality is gated behind behind a flag to not cause a breaking change (discussed in #2986).This should allow us to reenable loading
.editorconfigfiles, which is to be done in a subsequent PR.related to: #1724
related to: #2986
replaces: #3028
Test Plan
Added unit tests
cargo test -p biome_configuration editorconfig