Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): adds GraphQL parsing capabilities via feature #3238

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR adds support for parsing GraphQL files inside the workspace. The parsing is enabled only via a cargo feature called graphql.

This will allow us to enable GraphQL support inside our playground, so people can start experimenting.

Test Plan

CI should pass

@github-actions github-actions bot added A-Project Area: project A-Formatter Area: formatter A-Tooling Area: internal tools labels Jun 19, 2024
@ematipico ematipico changed the title feat(workspace): adds parsing capabilities via feature feat(workspace): adds GraphQL parsing capabilities via feature Jun 19, 2024
@ematipico ematipico requested review from a team June 19, 2024 13:52
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50226 50226 0
Passed 49119 49119 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.80% 97.80% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6534 6534 0
Passed 2084 2084 0
Failed 4450 4450 0
Panics 0 0 0
Coverage 31.89% 31.89% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18242 18242 0
Passed 13981 13981 0
Failed 4261 4261 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

crates/biome_graphql_syntax/src/file_source.rs Outdated Show resolved Hide resolved
crates/biome_graphql_syntax/src/file_source.rs Outdated Show resolved Hide resolved
crates/biome_graphql_syntax/src/file_source.rs Outdated Show resolved Hide resolved
crates/biome_graphql_syntax/src/file_source.rs Outdated Show resolved Hide resolved
crates/biome_service/src/file_handlers/mod.rs Outdated Show resolved Hide resolved
xtask/rules_check/src/lib.rs Show resolved Hide resolved
Copy link

codspeed-hq bot commented Jun 19, 2024

CodSpeed Performance Report

Merging #3238 will not alter performance

Comparing feat/graphql-support (1a60b15) with main (b36eba1)

Summary

✅ 90 untouched benchmarks

Co-authored-by: Ze-Zheng Wu <zezhengwu@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Project Area: project A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants