Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(useNamingConvention): add examples and improve explanations #3277

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Conaclos
Copy link
Member

Summary

Take feedbacks into account.

Test Plan

CI must pass.

@Conaclos Conaclos marked this pull request as ready for review June 24, 2024 11:01
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 24, 2024
Copy link

codspeed-hq bot commented Jun 24, 2024

CodSpeed Performance Report

Merging #3277 will not alter performance

Comparing conaclos/useNamingConvention/improve-docs (6aba917) with main (0c253b6)

Summary

✅ 90 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few grammar nits.

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Copy link

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the changes and I especially appreciate the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants