feat: enable linting for graphql #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
feat/enable-graphql-linting
branch
from
50be4e2
to
12b4d4f
Compare
github-actions
bot
added
A-Project
ematipico
force-pushed
the
feat/enable-graphql-linting
branch
from
12b4d4f
to
df164ad
Compare
CodSpeed Performance ReportMerging #3295 will not alter performanceComparing Summary
|
anonrig
approved these changes
Jun 26, 2024
arendjr
approved these changes
Jun 26, 2024
| parse, | ||
| fix_file_mode, | ||
| workspace, | ||
| should_format: _, // we don't have a formatter yet |
There was a problem hiding this comment.
You need to hurry up with this PR, or Denis would like a word 🤣
rishabh3112
pushed a commit
to rishabh3112/biome
that referenced
this pull request
Jul 6, 2024
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables linting of Graphql files inside our workspace. This won't change anything to the user, so it's safe to merge this PR.
Once merged, I will update the playground so it can show diagnostics from linting.
Also, I started seeing a lot of repeated code that we could refactor and make generic.
Test Plan
CI should pass