Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noExcessiveNestedTestSuites): more thoroughly check if describe call is an object member #3346

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Jul 3, 2024

Summary

This covers an additional edge case that I didn't account for initially in #2793.

related: #2599

Test Plan

added new snapshot tests

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jul 3, 2024
Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #3346 will degrade performances by 9.22%

Comparing dyc3:07-03-fix_lint_noexcessivenestedtestsuites_more_thoroughly_check_if_describe_call_is_an_object_member (877be49) with main (2319039)

Summary

❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dyc3:07-03-fix_lint_noexcessivenestedtestsuites_more_thoroughly_check_if_describe_call_is_an_object_member Change
db_2930068967297060348.json[cached] 12.5 ms 13.7 ms -9.22%

@ematipico ematipico merged commit c6f6b75 into biomejs:main Jul 4, 2024
11 of 12 checks passed
@dyc3 dyc3 deleted the 07-03-fix_lint_noexcessivenestedtestsuites_more_thoroughly_check_if_describe_call_is_an_object_member branch July 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants