Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(noRedeclare): ignore var named as the enclosing function expression name #3758

Merged

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 2, 2024

Summary

Previously, Biome reported foof as redeclared.

const f = function foo() { const foo = 0; }

Test Plan

I added a test

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Sep 2, 2024
@Conaclos Conaclos changed the title refactor(): ignore var named as function expression name refactor(noRedeclare): ignore var named as function expression name Sep 2, 2024
@Conaclos Conaclos merged commit 7bcda36 into main Sep 2, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/noRedeclare-ignore-variable-named-as-function-name branch September 2, 2024 10:57
@Conaclos Conaclos changed the title refactor(noRedeclare): ignore var named as function expression name refactor(noRedeclare): ignore var named as the enclosing function expression name Sep 2, 2024
Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #3758 will improve performances by 6.92%

Comparing conaclos/noRedeclare-ignore-variable-named-as-function-name (a9f1305) with main (b9203c7)

Summary

⚡ 1 improvements
✅ 98 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/noRedeclare-ignore-variable-named-as-function-name Change
react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +6.92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant