fix(useExhaustiveDependencies): make stableResult optional

crates/biome_js_analyze/src/lib.rs

@@ -177,7 +177,6 @@ mod tests {
     use std::slice;
 
     use crate::lint::correctness::use_exhaustive_dependencies::{Hook, HooksOptions};
-    use crate::react::hooks::StableHookResult;
     use crate::{analyze, AnalysisFilter, ControlFlow};
 
     #[ignore]
@@ -202,7 +201,7 @@ mod tests {
             name: "myEffect".to_string(),
             closure_index: Some(0),
             dependencies_index: Some(1),
-            stable_result: StableHookResult::None,
+            stable_result: None,
         };
         let rule_filter = RuleFilter::Rule("style", "useNodejsImportProtocol");
 

crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs

@@ -323,7 +323,7 @@ pub struct Hook {
     ///
     /// For example, for React's `useRef()` hook the value would be `true`,
     /// while for `useState()` it would be `[1]`.
-    pub stable_result: StableHookResult,
+    pub stable_result: Option<StableHookResult>,
 }
 
 impl DeserializableValidator for Hook {
@@ -358,12 +358,14 @@ impl ReactExtensiveDependenciesOptions {
     pub fn new(hooks: HooksOptions) -> Self {
         let mut result = ReactExtensiveDependenciesOptions::default();
         for hook in hooks.hooks {
-            if hook.stable_result != StableHookResult::None {
-                result.stable_config.insert(StableReactHookConfiguration {
-                    hook_name: hook.name.clone(),
-                    result: hook.stable_result,
-                    builtin: false,
-                });
+            if let Some(stable_result) = hook.stable_result {
+                if stable_result != StableHookResult::None {
+                    result.stable_config.insert(StableReactHookConfiguration {
+                        hook_name: hook.name.clone(),
+                        result: stable_result,
+                        builtin: false,
+                    });
+                }
             }
             if let (Some(closure_index), Some(dependencies_index)) =
                 (hook.closure_index, hook.dependencies_index)