fix(lint/noSelfAssign): correctly handle literals #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
A-Linter
ematipico
force-pushed
the
fix/self-assign-literal
branch
from
73f898d
to
ad7070a
Compare
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
approved these changes
Sep 22, 2023
ematipico
force-pushed
the
fix/self-assign-literal
branch
from
058c2ec
to
b6f8b2b
Compare
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #322
The rule handles string literals and numeric literals.
I remove the handling of javascript function calls, because it's not intended by design.
Test Plan
Added new test cases