Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser/html): parse doctype declarations #3962

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat(parser/html): parse doctype declarations #3962

merged 1 commit into from
Sep 18, 2024
+304 −16

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 17, 2024 •
edited
Loading

Summary

This PR completes everything necessary to parse all valid doctype directives.

Caution

This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.

Test Plan

Added tests.

@github-actions github-actions bot added A-Parser Area: parser L-HTML Language: HTML labels Sep 17, 2024
@dyc3 dyc3 requested review from a team September 17, 2024 17:11
@dyc3 dyc3 mentioned this pull request Sep 17, 2024
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3962 will not alter performance

Comparing 09-17-feat_parser_html_parse_doctype_declarations (17f704e) with main (a7b623a)

Summary

✅ 107 untouched benchmarks

chansuke
chansuke approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems nice to me

arendjr
arendjr approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one comment.

crates/biome_html_parser/src/lexer/mod.rs Outdated Show resolved Hide resolved
@dyc3 dyc3 force-pushed the 09-17-feat_parser_html_parse_doctype_declarations branch from f8667b1 to 17f704e Compare September 18, 2024 13:30
@dyc3 dyc3 merged commit 0ca9b69 into main Sep 18, 2024
14 checks passed
@dyc3 dyc3 deleted the 09-17-feat_parser_html_parse_doctype_declarations branch September 18, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

@chansuke chansuke chansuke approved these changes

Assignees
No one assigned
Labels
A-Parser Area: parser L-HTML Language: HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyc3 @chansuke @arendjr