Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to Rust 1.81 #3972

Merged
merged 2 commits into from
Sep 18, 2024
Merged

build: upgrade to Rust 1.81 #3972

merged 2 commits into from
Sep 18, 2024

Conversation

Conaclos
Copy link
Member

Summary

I addressed the new Clippy errors.

Test Plan

DI must pass.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages labels Sep 18, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this snapshot changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I wonder if it is not related to their change of implementation of sort and unstable_sort.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I remember. That's probably that

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48463 48463 0
Passed 47272 47272 0
Failed 1191 1191 0
Panics 0 0 0
Coverage 97.54% 97.54% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6569 6569 0
Passed 2202 2202 0
Failed 4367 4367 0
Panics 0 0 0
Coverage 33.52% 33.52% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 608 608 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.41% 89.41% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18430 18430 0
Passed 14112 14112 0
Failed 4318 4318 0
Panics 0 0 0
Coverage 76.57% 76.57% 0.00%

Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #3972 will not alter performance

Comparing conaclos/rust1.81 (be4f0a1) with main (756dd38)

Summary

✅ 107 untouched benchmarks

@github-actions github-actions bot added the A-Project Area: project label Sep 18, 2024
@Conaclos Conaclos merged commit 0a80daa into main Sep 18, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/rust1.81 branch September 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants