Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): implement noOctalEscape #3986

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat(linter): implement noOctalEscape #3986

merged 5 commits into from
Sep 19, 2024

Conversation

fireairforce
Copy link
Member

Summary

closes: #3929

Test Plan

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Sep 19, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3986 will degrade performances by 6.16%

Comparing fireairforce:feat-3929 (3ab3b1e) with main (a3193e7)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fireairforce:feat-3929 Change
❌ dojo_11880045762646467684.js[cached] 7.9 ms 8.5 ms -6.16%

@github-actions github-actions bot added the A-CLI Area: CLI label Sep 19, 2024
Conaclos
Conaclos approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could improve the diagnostic by reporting only the octal escape sequence. This is a possible future improvement.

@dyc3 dyc3 merged commit 33d0958 into biomejs:main Sep 19, 2024
11 of 12 checks passed
@WomB0ComB0 WomB0ComB0 mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Implement noOctalEscape - eslint/no-octal-escape
3 participants
@fireairforce @dyc3 @Conaclos