Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lint): set version field for new rules #3995

Merged
merged 1 commit into from
Sep 19, 2024
Merged

refactor(lint): set version field for new rules #3995

merged 1 commit into from
Sep 19, 2024

Conversation

Conaclos
Copy link
Member

Summary

#3974 didn't set the version field of new rules.

Test Plan

CI must pass

@Conaclos Conaclos marked this pull request as ready for review September 19, 2024 13:41
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Sep 19, 2024
@Conaclos Conaclos force-pushed the conaclos/set-version-of-new-rules branch from 596562f to 2bcb76a Compare September 19, 2024 13:41
@Conaclos Conaclos merged commit 6922305 into main Sep 19, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/set-version-of-new-rules branch September 19, 2024 13:54
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3995 will improve performances by 6.84%

Comparing conaclos/set-version-of-new-rules (2bcb76a) with main (b4d9d9e)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/set-version-of-new-rules Change
⚡ db_17847247775464589309.json[cached] 14.2 ms 13.3 ms +6.84%

@WomB0ComB0 WomB0ComB0 mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conaclos @dyc3