-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint/noPrototypeBuiltins): add code fix action and cover scenarios from prefer-object-has-own
#3997
Conversation
CodSpeed Performance ReportMerging #3997 will not alter performanceComparing Summary
|
c168909
to
b08c72c
Compare
Hi @kaioduarte! I am sorry, I completely missed the fact that we already [noPrototypeBuiltins](have https://biomejs.dev/linter/rules/no-prototype-builtins/) which has some overlap with the rule you are implementing. I think we could improve |
Sounds good, I'll take a look at that later. Should I add |
Yes. This will avoid thinking that the rule was not covered. |
b08c72c
to
7c37f2e
Compare
I haven't done the read-only part yet, I only incorporated the changes from the other rule while adapting the code fix. |
prefer-object-has-own
LGTM
This could be left for another PR. |
Summary
Closes #3927
Test Plan
Snapshots + CI