Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce usage of to_ascii_lowercase_cow #4014

Merged

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented Sep 20, 2024

Summary

Basically the same ideas as oxc-project/oxc#5586.
Enforce usage of biome_string_case::StrExtension::to_ascii_lowercase_cow with Clippy to minimize memory allocation.

Test Plan

All existing tests should pass.

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages L-HTML Language: HTML labels Sep 20, 2024
@minht11 minht11 requested review from a team September 20, 2024 15:30
@minht11 minht11 self-assigned this Sep 20, 2024
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t realise this was so easy with Clippy 👍 And I do like we use our own utils indeed.

Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #4014 will improve performances by 9.06%

Comparing minht11:chore/enforce-to_ascii_lowercase_cow-usage (70c37db) with main (1a87927)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main minht11:chore/enforce-to_ascii_lowercase_cow-usage Change
db_17847247775464589309.json[cached] 13.9 ms 12.8 ms +9.06%

@dyc3 dyc3 merged commit 8616d75 into biomejs:main Sep 20, 2024
12 of 13 checks passed
@dyc3
Copy link
Contributor

dyc3 commented Sep 20, 2024

Whoops, I didn't see the check deps job failure. Fixed in #4016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser L-CSS Language: CSS L-HTML Language: HTML L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants