fix(parser/html): add param to void elements list
#4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4020 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
09-20-fix_parser_html_add_param_to_void_elements_list
branch
from
015953d
to
617285d
Compare
dyc3
deleted the
09-20-fix_parser_html_add_param_to_void_elements_list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
paramis one of the void elements a part of HTML 4 originally (I think?), retained for backwards compatibility in HTML 5.See: https://www.w3.org/TR/2011/WD-html5-author-20110809/the-param-element.html
Test Plan
Tested manually, and against a prettier test that uses that element. Also added a parser snapshot test.