-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(linter): performance improvement for css semantic model #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Core
Area: core
A-Linter
Area: linter
L-CSS
Language: CSS
labels
Sep 22, 2024
togami2864
changed the title
perf(linter): Performance improvement for css semantic model
perf(linter): performance improvement for css semantic model
Sep 22, 2024
CodSpeed Performance ReportMerging #4044 will degrade performances by 6.6%Comparing Summary
Benchmarks breakdown
|
dyc3
reviewed
Sep 22, 2024
ematipico
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @togami2864 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to the profile, get_rule_by_range and process_selector significantly affect performance.
I implemented the following improvements to address these issues:
FxHashMap
withBTreeMap
to searchrange_to_rule
more efficiently.Cow
to minimize unnecessary memory allocation inprocess_selector
Test Plan
CI should pass