Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine README.kr.md #4110

Merged
merged 3 commits into from
Nov 4, 2024
Merged

chore: refine README.kr.md #4110

merged 3 commits into from
Nov 4, 2024

Conversation

StationSoen
Copy link
Contributor

Summary

Refine Korean README Translation.

  • Update some sections that differ from the README.md.
  • Refine some slightly awkward sentences in the Korean README.md.
  • Update the Japanese link to the default link.

Tickets

Test Plan

  • I’ll suggest a native Korean speaker as a reviewer, if that’s okay with you.

@StationSoen StationSoen force-pushed the refine-korean-readme-translation branch from f082292 to 49c11e4 Compare September 27, 2024 17:48
@Conaclos
Copy link
Member

Conaclos commented Oct 1, 2024

I’ll suggest a native Korean speaker as a reviewer, if that’s okay with you.

Yeah. Please :)

quiple
quiple suggested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@quiple quiple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원본 영어 문서에 맞춰서 업데이트 및 번역을 개선하고 맞춤법을 수정했습니다.

packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
packages/@biomejs/biome/README.kr.md Outdated Show resolved Hide resolved
@ematipico
Copy link
Member

@StationSoen can you apply the suggestions?

@StationSoen
Copy link
Contributor Author

StationSoen commented Nov 4, 2024 •
edited
Loading

@ematipico Sorry for the delay. I’ve applied all the feedback since it was very helpful.

@ematipico ematipico merged commit 058ff16 into biomejs:main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiple quiple quiple requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Refine Korean README.md
4 participants
@StationSoen @Conaclos @ematipico @quiple