Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use code blocks to avoid rendering issue on the website #4167

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ematipico
Copy link
Member

Summary

The website isn't deploying anymore because of a build issue.

The issue was caused by using a template literal syntax wasn't wrapped in a code block.

Test Plan

Merge it, and the new website should be deployed.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 2, 2024
@ematipico ematipico merged commit 484ff85 into main Oct 2, 2024
11 checks passed
@ematipico ematipico deleted the docs/fix-rendering-issue branch October 2, 2024 15:02
Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #4167 will degrade performances by 6.84%

Comparing docs/fix-rendering-issue (9fd8554) with main (5e37220)

Summary

❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main docs/fix-rendering-issue Change
router_17129688031671448157.ts[cached] 2.1 ms 2.2 ms -6.84%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant