-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useExplicitFunctionReturnType): support typed function expressions #4174
Merged
Conaclos
merged 7 commits into
biomejs:main
from
kaykdm:support-typed-function-expressions
Oct 7, 2024
Merged
feat(useExplicitFunctionReturnType): support typed function expressions #4174
Conaclos
merged 7 commits into
biomejs:main
from
kaykdm:support-typed-function-expressions
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctionReturnType rule
github-actions
bot
added
A-Linter
Area: linter
L-JavaScript
Language: JavaScript and super languages
labels
Oct 4, 2024
CodSpeed Performance ReportMerging #4174 will degrade performances by 33.19%Comparing Summary
Benchmarks breakdown
|
Conaclos
reviewed
Oct 7, 2024
crates/biome_js_analyze/src/lint/nursery/use_explicit_function_return_type.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_explicit_function_return_type.rs
Outdated
Show resolved
Hide resolved
Conaclos
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made it! Thanks for your amazing contribution 💗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
related: #2017
This PR introduces the ability to detect typed function expressions in the useExplicitFunctionReturnType rule.
todos:
as
or<>