fix(css_parser): accept more emoji #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
dyc3
approved these changes
Oct 4, 2024
Conaclos
force-pushed
the
conaclos/css-parser-accept-extra-emoji
branch
from
674eb22 to
ae5f63b
Compare
Conaclos
force-pushed
the
conaclos/css-parser-accept-extra-emoji
branch
from
ae5f63b to
4d53371
Compare
Conaclos
force-pushed
the
conaclos/css-parser-accept-extra-emoji
branch
from
4d53371 to
8b1e3bf
Compare
ematipico
reviewed
Oct 4, 2024
crates/biome_css_analyze/tests/specs/nursery/noIrregularWhitespace/invalid.css.snap
Outdated
Show resolved
Hide resolved
Conaclos
force-pushed
the
conaclos/css-parser-accept-extra-emoji
branch
from
8b1e3bf to
f353ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3627
Browsers accept more emoji than the standard allows.
Biome now accepts these additional emoji.
Test Plan
I added some tests.