-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add useGoogleFontDisplay
rule
#4264
Conversation
CodSpeed Performance ReportMerging #4264 will not alter performanceComparing Summary
|
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a URL parser for a small case seems too much. I would consider some other alternatives
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
01be3cd
to
d5b963a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code can be improved to make it more maintainable, and we need to update the diagnostic and the docs, because we mix font-display
and display
parameter, and we call both of them parameters. If this is intended, the distinction isn't clear.
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_google_font_display.rs
Outdated
Show resolved
Hide resolved
50d7bf7
to
83d889d
Compare
We can merge after we resolve the conflicts |
…ay.rs Co-authored-by: togami <62130798+togami2864@users.noreply.github.com>
83d889d
to
62d87f8
Compare
Co-authored-by: togami <62130798+togami2864@users.noreply.github.com>
Summary
Implement google-font-display from eslint-plugin-next.
Test Plan
Snapshots + CI