Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add useGoogleFontDisplay rule #4264

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

kaioduarte
Copy link
Contributor

Summary

Implement google-font-display from eslint-plugin-next.

Test Plan

Snapshots + CI

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Oct 12, 2024
Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #4264 will not alter performance

Comparing kaioduarte:google-font-display (62d87f8) with main (5a1710f)

Summary

✅ 101 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a URL parser for a small case seems too much. I would consider some other alternatives

@github-actions github-actions bot added the A-Changelog Area: changelog label Oct 13, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code can be improved to make it more maintainable, and we need to update the diagnostic and the docs, because we mix font-display and display parameter, and we call both of them parameters. If this is intended, the distinction isn't clear.

@kaioduarte kaioduarte force-pushed the google-font-display branch 2 times, most recently from 50d7bf7 to 83d889d Compare October 16, 2024 01:21
@ematipico
Copy link
Member

We can merge after we resolve the conflicts

@ematipico ematipico merged commit 2a05cd4 into biomejs:main Oct 17, 2024
12 checks passed
@kaioduarte kaioduarte deleted the google-font-display branch October 17, 2024 12:58
Conaclos pushed a commit that referenced this pull request Oct 18, 2024
Co-authored-by: togami <62130798+togami2864@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants