-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parser/js): rename import assertions to import attributes #4373
refactor(parser/js): rename import assertions to import attributes #4373
Conversation
Parser conformance results onjs/262
🎉 Fixed (8):
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
🔥 Regression (2):
|
CodSpeed Performance ReportMerging #4373 will degrade performances by 7.25%Comparing Summary
Benchmarks breakdown
|
93ab39d
to
1afed06
Compare
1afed06
to
15726c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should rename JsImportAttribute
into JsImportWithClause
, attribute
into with_clause
and drop Entry
of the remaining nodes. What do you think?
I think |
Summary
Renames things related to import "assertions" to import "attributes"
closes #4372
Test Plan
CI should pass.