Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(restricted_glob): add Eq impls #4388

Merged
merged 1 commit into from
Oct 25, 2024
Merged

refactor(restricted_glob): add Eq impls #4388

merged 1 commit into from
Oct 25, 2024

Conversation

Conaclos
Copy link
Member

Summary

Reviewing #4376, I noticed that RetsrictedGLob was not implementing Eq, PartialEq and Hash.
This PR fixes it.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 25, 2024
@Conaclos Conaclos mentioned this pull request Oct 25, 2024
Merged
@Conaclos Conaclos merged commit 3cef1f2 into main Oct 25, 2024
11 checks passed
@Conaclos Conaclos deleted the conaclos/restricted_glob_eq-impl branch October 25, 2024 14:35
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #4388 will not alter performance

Comparing conaclos/restricted_glob_eq-impl (3341980) with main (28a2a6c)

Summary

✅ 101 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conaclos @ematipico