Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move biome_lsp/converters to a separate crate #4407

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

Princesseuh
Copy link
Contributor

@Princesseuh Princesseuh commented Oct 28, 2024

Summary

biome_lsp has a lot of nifty converters and tools for working with biome_rowan's structs and converting them to LSP formats. Unfortunately, biome_lsp is a private crate, so none of those tools were exported.

This PR moves those utilities into a separate biome_lsp_converters crate that is public, so that people (just me, maybe) can use them.

Test Plan

Moved the tests as well, so the same testing strategy still applies.

@github-actions github-actions bot added the A-LSP Area: language server protocol label Oct 28, 2024
Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #4407 will not alter performance

Comparing Princesseuh:main (060160a) with main (559128f)

Summary

✅ 99 untouched benchmarks

@ematipico
Copy link
Member

ematipico commented Oct 28, 2024

We have a task just new-crate that updates this file: https://github.com/biomejs/biome/blob/main/knope.toml

Can you update it manually and add the new crate? It will help with automation release.

Finally, run just f to format the cargo files (you might need to run just install-tools to install taplo)

@Princesseuh
Copy link
Contributor Author

Should be done! Let me know if I need to update anything else.

@ematipico ematipico merged commit eb13885 into biomejs:main Oct 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LSP Area: language server protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants