Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename action to use the internal naming convention #4420

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ematipico
Copy link
Member

Summary

I renamed sortJsxProps to use our internal naming convention to useSortedAttributes. While in JSX they are usually called props, we use attributes, even in the formatter. That's because in HTML they are called like this.

Since we don't document actions yet, I also changed the version to 2.0.0, so we avoid unintentional breaking changes.

Test Plan

CI should pass

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 29, 2024
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #4420 will not alter performance

Comparing chore/rename-action (84dd8b2) with main (f543f12)

Summary

✅ 99 untouched benchmarks

@ematipico ematipico merged commit 92286ab into main Oct 29, 2024
12 checks passed
@ematipico ematipico deleted the chore/rename-action branch October 29, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants