Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(assists): add action options #4422

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

Conaclos
Copy link
Member

Summary

The PR adds options to assist actions.
We need them to configure organizeImports.

I renamed RuleAssistConfiguration to RuleAssistPlainConfiguration and I created new types RuleAssistConfiguration and RuleAssistWithOptions. These types mimic RuleConfiguration and RuleWithOptions.

Test Plan

I manually tested the new feature.

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages labels Oct 29, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48421 48421 0
Passed 47221 47221 0
Failed 1200 1200 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6580 6580 0
Passed 2205 2205 0
Failed 4375 4375 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 607 607 0
Failed 73 73 0
Panics 0 0 0
Coverage 89.26% 89.26% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18508 18508 0
Passed 14168 14168 0
Failed 4340 4340 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #4422 will not alter performance

Comparing conaclos/assists-add-options (7b5fbbf) with main (92286ab)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos merged commit d4d6a93 into main Oct 29, 2024
12 checks passed
@Conaclos Conaclos deleted the conaclos/assists-add-options branch October 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants