Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_analyze): skip noAutofocus check if eligible #4475

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

seeintea
Copy link
Contributor

@seeintea seeintea commented Nov 6, 2024

Summary

Closes #4339

Use a custom visitor to detect that an element with the autofocus attribute is a child element of dialog element or popover attribute.

Test Plan

Updated the snapshot tests

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 6, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a nit around docs

Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #4475 will improve performances by 6.02%

Comparing seeintea:fix/no_autofocus (00a2c81) with main (d9d7bd7)

Summary

⚡ 1 improvements
✅ 98 untouched benchmarks

Benchmarks breakdown

Benchmark main seeintea:fix/no_autofocus Change
jquery.min_16034160674129647344.js[cached] 28.1 ms 26.5 ms +6.02%

@ematipico ematipico added the S-Merge for next minor Status: the PR should be merged in the next minor label Nov 6, 2024
@ematipico ematipico merged commit 13904f2 into biomejs:main Nov 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Merge for next minor Status: the PR should be merged in the next minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 lint/a11y/noAutofocus contradicts with MDN recommendations for <dialog>
2 participants