Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useValidAutocomplete): use Ast query instead of Aria #4516

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Conaclos
Copy link
Member

Summary

Refactor useValidAUtocomplete to use the Ast query instead of the Aria query.
I also simplified the implementation by using JsxAttributeList::find_by_name and AnyJsxElement instead of a custom type.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 12, 2024
@Conaclos Conaclos force-pushed the conaclos/useValidAutocomplete-use-ast-query branch 2 times, most recently from a503775 to 5f49412 Compare November 12, 2024 14:50
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4516 will not alter performance

Comparing conaclos/useValidAutocomplete-use-ast-query (25ff10b) with main (0c89612)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos force-pushed the conaclos/useValidAutocomplete-use-ast-query branch from 5f49412 to 25ff10b Compare November 12, 2024 15:37
@Conaclos Conaclos merged commit 1be5918 into main Nov 12, 2024
11 checks passed
@Conaclos Conaclos deleted the conaclos/useValidAutocomplete-use-ast-query branch November 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants