refactor(js_semantic): handle bindings with bogus names #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
the
L-JavaScript
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Nov 2, 2023
| false | ||
| }; | ||
| let scope_id = self.current_scope_mut().scope_id; | ||
| self.stash.push_back(SemanticEvent::DeclarationFound { | ||
| scope_id, | ||
| hoisted_scope_id, | ||
| name_token, | ||
| range: node.syntax().text_range(), |
There was a problem hiding this comment.
Is this intentional? Should it be text_trimmed_range?
There was a problem hiding this comment.
It is intentional. We use text_range everywhere.
I still plan to change it to text_trimmed_range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The semantic model assumes that every identifier binding has an associated semantic binding.
This assumption is broken in one case: when the binding has a bogus name.
This PR improves code robustness by handling bindings with a bogus name.
This could fix #650.
Test Plan
I didn't figure out how to create a binding with a bogus name.