Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_semantic): add semantic scope to mapped types #958

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Conaclos
Copy link
Member

Summary

Fix #953

Test Plan

New test added.

@Conaclos Conaclos temporarily deployed to Website deployment November 29, 2023 11:44 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Nov 29, 2023
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13453 13453 0
Failed 4191 4191 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@Conaclos Conaclos force-pushed the conaclos/lint/noRedeclare/953 branch 2 times, most recently from dc32df0 to 433a313 Compare November 29, 2023 13:01
@Conaclos Conaclos temporarily deployed to Website deployment November 29, 2023 13:01 — with GitHub Actions Inactive
@Conaclos Conaclos force-pushed the conaclos/lint/noRedeclare/953 branch from 433a313 to 02c5b18 Compare November 29, 2023 13:13
@Conaclos Conaclos temporarily deployed to Website deployment November 29, 2023 13:13 — with GitHub Actions Inactive
@Conaclos Conaclos merged commit d7a5d8c into main Nov 29, 2023
@Conaclos Conaclos deleted the conaclos/lint/noRedeclare/953 branch November 29, 2023 13:24
yossydev pushed a commit to yossydev/biome that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
1 participant